Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH] skel.ebuild: Reorder S after SRC_URI
Date: Wed, 27 Nov 2019 09:28:13
Message-Id: 20191127092742.306075-1-mgorny@gentoo.org
1 Update the skel variable order to place S immediately after SRC_URI.
2 This seems to be a growing trend, and is quite reasonable given that
3 S usually matches the archive name, and e.g. if SRC_URI uses MY_P,
4 then S usually uses it as well:
5
6 SRC_URI="http://example.com/${MY_P}.tar.gz"
7 S=${WORKDIR}/${MY_P}
8
9 Signed-off-by: Michał Górny <mgorny@g.o>
10 ---
11 skel.ebuild | 13 ++++++-------
12 1 file changed, 6 insertions(+), 7 deletions(-)
13
14 diff --git a/skel.ebuild b/skel.ebuild
15 index 9c9e6b366eb9..6e855e8fa6cc 100644
16 --- a/skel.ebuild
17 +++ b/skel.ebuild
18 @@ -32,6 +32,12 @@ HOMEPAGE="https://foo.example.org/"
19 # Portage.
20 SRC_URI="ftp://foo.example.org/${P}.tar.gz"
21
22 +# Source directory; the dir where the sources can be found (automatically
23 +# unpacked) inside ${WORKDIR}. The default value for S is ${WORKDIR}/${P}
24 +# If you don't need to change it, leave the S= line out of the ebuild
25 +# to keep it tidy.
26 +#S="${WORKDIR}/${P}"
27 +
28
29 # License of the package. This must match the name of file(s) in the
30 # licenses/ directory. For complex license combination see the developer
31 @@ -99,13 +105,6 @@ IUSE="gnome X"
32 #BDEPEND="virtual/pkgconfig"
33
34
35 -# Source directory; the dir where the sources can be found (automatically
36 -# unpacked) inside ${WORKDIR}. The default value for S is ${WORKDIR}/${P}
37 -# If you don't need to change it, leave the S= line out of the ebuild
38 -# to keep it tidy.
39 -#S="${WORKDIR}/${P}"
40 -
41 -
42 # The following src_configure function is implemented as default by portage, so
43 # you only need to call it if you need a different behaviour.
44 #src_configure() {
45 --
46 2.24.0

Replies

Subject Author
Re: [gentoo-dev] [PATCH] skel.ebuild: Reorder S after SRC_URI Ulrich Mueller <ulm@g.o>