Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH] skel.ebuild: Reorder S after SRC_URI
Date: Wed, 27 Nov 2019 09:28:13
Message-Id: 20191127092742.306075-1-mgorny@gentoo.org
Update the skel variable order to place S immediately after SRC_URI.
This seems to be a growing trend, and is quite reasonable given that
S usually matches the archive name, and e.g. if SRC_URI uses MY_P,
then S usually uses it as well:

    SRC_URI="http://example.com/${MY_P}.tar.gz"
    S=${WORKDIR}/${MY_P}

Signed-off-by: Michał Górny <mgorny@g.o>
---
 skel.ebuild | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/skel.ebuild b/skel.ebuild
index 9c9e6b366eb9..6e855e8fa6cc 100644
--- a/skel.ebuild
+++ b/skel.ebuild
@@ -32,6 +32,12 @@ HOMEPAGE="https://foo.example.org/"
 # Portage.
 SRC_URI="ftp://foo.example.org/${P}.tar.gz"
 
+# Source directory; the dir where the sources can be found (automatically
+# unpacked) inside ${WORKDIR}.  The default value for S is ${WORKDIR}/${P}
+# If you don't need to change it, leave the S= line out of the ebuild
+# to keep it tidy.
+#S="${WORKDIR}/${P}"
+
 
 # License of the package.  This must match the name of file(s) in the
 # licenses/ directory.  For complex license combination see the developer
@@ -99,13 +105,6 @@ IUSE="gnome X"
 #BDEPEND="virtual/pkgconfig"
 
 
-# Source directory; the dir where the sources can be found (automatically
-# unpacked) inside ${WORKDIR}.  The default value for S is ${WORKDIR}/${P}
-# If you don't need to change it, leave the S= line out of the ebuild
-# to keep it tidy.
-#S="${WORKDIR}/${P}"
-
-
 # The following src_configure function is implemented as default by portage, so
 # you only need to call it if you need a different behaviour.
 #src_configure() {
-- 
2.24.0

Replies

Subject Author
Re: [gentoo-dev] [PATCH] skel.ebuild: Reorder S after SRC_URI Ulrich Mueller <ulm@g.o>