Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: hasufell@g.o
Subject: Re: [gentoo-dev] [PATCH] multilib-minimal.eclass: allow relative paths to $S for DOCS variable wrt #468092
Date: Thu, 02 May 2013 16:41:23
Message-Id: 20130502183128.56562719@gentoo.org
In Reply to: [gentoo-dev] [PATCH] multilib-minimal.eclass: allow relative paths to $S for DOCS variable wrt #468092 by hasufell
1 On Thu, 02 May 2013 18:24:19 +0200
2 hasufell <hasufell@g.o> wrote:
3
4 > currently default_src_install is carried out in $BUILD_DIR and not in $S
5 >
6 > that means people have to do something like this:
7 > DOCS=( "${S}"/ChangeLog{,.libffi,.libgcj,.v1} "${S}"/README )
8 >
9 > The attached patch is a bit ugly, but I don't see a better way. It will
10 > allow:
11 > DOCS=( ChangeLog{,.libffi,.libgcj,.v1} README )
12
13 Erm, now you're hacking default_src_install in one place, and inlining
14 it in the other. Please keep it consistent and either inline it in both
15 places, or hack in both places.
16
17 Also, HTML_DOCS suffer the same issue.
18
19 --
20 Best regards,
21 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies