Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] multilib-minimal.eclass: allow relative paths to $S for DOCS variable wrt #468092
Date: Thu, 02 May 2013 16:52:06
Message-Id: 518299AC.4010705@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] multilib-minimal.eclass: allow relative paths to $S for DOCS variable wrt #468092 by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 On 05/02/2013 06:31 PM, Micha³ Górny wrote:
5 > On Thu, 02 May 2013 18:24:19 +0200 hasufell <hasufell@g.o>
6 > wrote:
7 >
8 >> currently default_src_install is carried out in $BUILD_DIR and
9 >> not in $S
10 >>
11 >> that means people have to do something like this: DOCS=(
12 >> "${S}"/ChangeLog{,.libffi,.libgcj,.v1} "${S}"/README )
13 >>
14 >> The attached patch is a bit ugly, but I don't see a better way.
15 >> It will allow: DOCS=( ChangeLog{,.libffi,.libgcj,.v1} README )
16 >
17 > Erm, now you're hacking default_src_install in one place, and
18 > inlining it in the other. Please keep it consistent and either
19 > inline it in both places, or hack in both places.
20
21 why?
22
23 >
24 > Also, HTML_DOCS suffer the same issue.
25 >
26
27 not a PMS function afais
28
29
30 what I don't know for sure is: do all PMs accept empty string as
31 argument for "dodoc" without failing?
32 Otherwise I could just use a second variable and unset DOCS.
33 -----BEGIN PGP SIGNATURE-----
34 Version: GnuPG v2.0.19 (GNU/Linux)
35 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
36
37 iQEcBAEBAgAGBQJRgpmsAAoJEFpvPKfnPDWz5V4IAIe3lOIYMFU4j9i3qJ/roR/G
38 Z9qZFNDDHBzGhq8ycQ7rswrIE54FhTJ56Y/9l1ng4eutvRly4DCCBd9wT3FISPCq
39 3W3ltA/l78vd+iFsFHrUqnyUBCpi9gVEp59uvZrWzjRquVsnUuYv72wpVl2k4+2z
40 PV4iP6SbUBQJzMlQSsixAnMbJKtPstMFRAG83bLhy4IrvNBC9bRaFqO09De07IX+
41 VFcKoSJMy+NrVblrm9E9HjaxA48z0Od0EcLHvODAPscv9+auSsF9boWZyjCY2iZ0
42 lKhthUv7ymZExpYE7tBtq13ykw1g7irID8UxVZdg53FOihO8TjIB0kxkAFDjK7I=
43 =jBrb
44 -----END PGP SIGNATURE-----

Replies