Re: [gentoo-dev] RFC: cmake.eclass

[Krzysiek Pawlik]

Donnie Berkholz wrote:
>> I've wrote an eclass that makes writing ebuilds for such packages a little
>> easier - it provides an ecmake function that takes care of few needed variables,
>> prefix and such.
>
> Great! When's the scons one coming? =)

I don't know scons ;)

>> #
>> # Original Author: nelchael
>> # Purpose: Automate src_install and src_compile for packages using cmake
>> #
>
> This would be a great opportunity to start using real eclass
> documentation (e.g. that found in eutils.eclass) so we can autogenerate
> a useful manpage on how to use it.

Done.

>> # If you want to build in source tree set CMAKE_IN_SOURCE_BUILD to anything:
>> [[ -n "${CMAKE_IN_SOURCE_BUILD}" ]] && CMAKE_BUILD_DIR="${S}"
>
> Why would I want to do that? Some documentation would help.

Added: some packages refuse to build out of source, so it may be needed in some
cases.

>> function ecmake() {
>
> Why are some functions declared with 'function' and others not?

Fixed: added '^function '

>> 		-DCMAKE_CXX_COMPILER="$(type -P $(tc-getCXX))" \
>
> Why the 'type -P' bit?

To get the full path to $CC and $CXX

>> 	make DESTDIR="${D}" install || die "make install failed"
>
> Does emake work?

It should -> fixed.

Attached is new version and a diff to previous.

-- 
Krzysiek Pawlik   <nelchael at gentoo.org>   key id: 0xBC555551
desktop-misc, desktop-dock, x86, java, apache, ppc...