Re: [gentoo-dev] RFC: cmake.eclass

[Donnie Berkholz]

On 12:51 Sun 04 Nov     , Krzysiek Pawlik wrote:
> A little introduction: cmake is an alternative for autotools, more and more
> packages are using it (and some new big ones are on the way, KDE4 for example).
>
> I've wrote an eclass that makes writing ebuilds for such packages a little
> easier - it provides an ecmake function that takes care of few needed variables,
> prefix and such.

Great! When's the scons one coming? =)

> # Copyright 1999-2007 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> # $Header: $
>
> #
> # Original Author: nelchael
> # Purpose: Automate src_install and src_compile for packages using cmake
> #

This would be a great opportunity to start using real eclass 
documentation (e.g. that found in eutils.eclass) so we can autogenerate 
a useful manpage on how to use it.

> # If you want to build in source tree set CMAKE_IN_SOURCE_BUILD to anything:
> [[ -n "${CMAKE_IN_SOURCE_BUILD}" ]] && CMAKE_BUILD_DIR="${S}"

Why would I want to do that? Some documentation would help.

> function ecmake() {

Why are some functions declared with 'function' and others not?

> 		-DCMAKE_CXX_COMPILER="$(type -P $(tc-getCXX))" \

Why the 'type -P' bit?

> 	make DESTDIR="${D}" install || die "make install failed"

Does emake work?

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list