Gentoo Archives: gentoo-dev

From: Thomas Deutschmann <whissi@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2] acct-user.eclass: allow opt-out of user modification
Date: Fri, 08 Jan 2021 21:05:54
Message-Id: faea8644-4210-8caf-329d-0b1b62933f62@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH v2] acct-user.eclass: allow opt-out of user modification by "Michał Górny"
1 On 2021-01-08 21:58, Michał Górny wrote:
2 >> +# @ECLASS-VARIABLE: ACCT_USER_ALREADY_EXISTS
3 >> +# @INTERNAL
4 >> +# @DESCRIPTION:
5 >> +# Status variable which indicates if user already exists.
6 >
7 > Please prefix internal variables with an underscore.
8
9 You mean renaming ACCT_USER_ALREADY_EXISTS to _ACCT_USER_ALREADY_EXISTS?
10
11 Then _ACCT_USER_ALREADY_EXISTS would deviate from ACCT_USER_NAME which
12 has no underscore prefix and is also marked as internal variable.
13
14 Or should I fix both?
15
16
17 --
18 Regards,
19 Thomas Deutschmann / Gentoo Linux Developer
20 fpr: C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

Attachments

File name MIME type
OpenPGP_signature.asc application/pgp-signature

Replies