| 1 |
On Fri, 2021-01-08 at 22:05 +0100, Thomas Deutschmann wrote: |
| 2 |
> On 2021-01-08 21:58, Michał Górny wrote: |
| 3 |
> > > +# @ECLASS-VARIABLE: ACCT_USER_ALREADY_EXISTS |
| 4 |
> > > +# @INTERNAL |
| 5 |
> > > +# @DESCRIPTION: |
| 6 |
> > > +# Status variable which indicates if user already exists. |
| 7 |
> > |
| 8 |
> > Please prefix internal variables with an underscore. |
| 9 |
> |
| 10 |
> You mean renaming ACCT_USER_ALREADY_EXISTS to _ACCT_USER_ALREADY_EXISTS? |
| 11 |
|
| 12 |
Yes. |
| 13 |
|
| 14 |
> |
| 15 |
> Then _ACCT_USER_ALREADY_EXISTS would deviate from ACCT_USER_NAME which |
| 16 |
> has no underscore prefix and is also marked as internal variable. |
| 17 |
> |
| 18 |
> Or should I fix both? |
| 19 |
|
| 20 |
ACCT_USER_NAME is a 'visible' variable. I probably shouldn't have |
| 21 |
marked it internal. |
| 22 |
|
| 23 |
-- |
| 24 |
Best regards, |
| 25 |
Michał Górny |
Archives