| 1 |
On 20 February 2015 at 04:06, Jeroen Roovers <jer@g.o> wrote: |
| 2 |
> On Wed, 18 Feb 2015 19:58:29 +0800 |
| 3 |
> Ben de Groot <yngwin@g.o> wrote: |
| 4 |
> |
| 5 |
>> The attached patch proposes two helper functions to be added to |
| 6 |
>> qmake-utils.eclass. These functions echo the correct directory where |
| 7 |
>> qt binaries such as moc and lrelease are located. They can be used in |
| 8 |
>> ebuilds when such binaries need to be called directly. (Ebuilds should |
| 9 |
>> not rely on qtchooser for this.) |
| 10 |
>> |
| 11 |
>> Please review before I commit. |
| 12 |
> |
| 13 |
> Looks good (barring what Davide noted). |
| 14 |
> |
| 15 |
> Do you have a list of ebuilds that might benefit? |
| 16 |
> |
| 17 |
> I know net-analyzer/wireshark might, but it doesn't even use |
| 18 |
> qmake-utils.eclass right now simply because it doesn't use qmake (but it |
| 19 |
> does use moc and uic, so I wouldn't expect to find those functions in an |
| 20 |
> eclass seemingly about qmake). |
| 21 |
> |
| 22 |
|
| 23 |
Committed, with improvements by Davide. |
| 24 |
|
| 25 |
Based on a quick qgrep for lrelease/moc/uic, packages that would benefit are: |
| 26 |
|
| 27 |
app-cdr/qpxtool |
| 28 |
app-crypt/pinentry |
| 29 |
app-editors/znotes |
| 30 |
app-text/diffpdf |
| 31 |
app-text/qpdfview |
| 32 |
dev-util/universalindentgui |
| 33 |
games-board/qgo |
| 34 |
games-emulation/higan |
| 35 |
games-kids/cubetest |
| 36 |
games-util/higan-purify |
| 37 |
media-sound/lastfmplayer |
| 38 |
media-sound/musescore |
| 39 |
media-video/smplayer |
| 40 |
media-video/videocut |
| 41 |
media-video/vlc |
| 42 |
media-video/xvideoservicethief |
| 43 |
net-analyzer/wireshark |
| 44 |
net-im/psi |
| 45 |
net-im/skype |
| 46 |
net-p2p/transmission |
| 47 |
sci-calculators/speedcrunch |
| 48 |
sci-geosciences/gpsbabel |
| 49 |
sci-geosciences/merkaartor |
| 50 |
sci-visualization/qtiplot/ |
| 51 |
sys-boot/unetbootin |
| 52 |
|
| 53 |
-- |
| 54 |
Cheers, |
| 55 |
|
| 56 |
Ben | yngwin |
| 57 |
Gentoo developer |
Archives