Gentoo Archives: gentoo-dev

From: Jeroen Roovers <jer@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] qmake-utils.eclass: add qt{4,5}_get_bindir helper functions
Date: Thu, 19 Feb 2015 20:06:45
Message-Id: 20150219210631.5424edc6@marga.jer-c2.orkz.net
In Reply to: [gentoo-dev] [PATCH] qmake-utils.eclass: add qt{4,5}_get_bindir helper functions by Ben de Groot
1 On Wed, 18 Feb 2015 19:58:29 +0800
2 Ben de Groot <yngwin@g.o> wrote:
3
4 > The attached patch proposes two helper functions to be added to
5 > qmake-utils.eclass. These functions echo the correct directory where
6 > qt binaries such as moc and lrelease are located. They can be used in
7 > ebuilds when such binaries need to be called directly. (Ebuilds should
8 > not rely on qtchooser for this.)
9 >
10 > Please review before I commit.
11
12 Looks good (barring what Davide noted).
13
14 Do you have a list of ebuilds that might benefit?
15
16 I know net-analyzer/wireshark might, but it doesn't even use
17 qmake-utils.eclass right now simply because it doesn't use qmake (but it
18 does use moc and uic, so I wouldn't expect to find those functions in an
19 eclass seemingly about qmake).
20
21
22 jer

Replies