Re: [gentoo-dev] Re: gentoo-x86 commit in app-forensics/memdump: memdump-1.0.1.ebuild ChangeLog

[Nirbheek Chauhan]

On Mon, Jan 5, 2009 at 5:37 AM, Torsten Veller <ml-en@××××××.net> wrote:
> * "Patrick Lauer (patrick)" <patrick@g.o>:
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-forensics/memdump/memdump-1.0.1.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-forensics/memdump/memdump-1.0.1.ebuild?rev=1.1&content-type=text/plain
>>
>> Index: memdump-1.0.1.ebuild
>> ===================================================================
>> # Copyright 1999-2009 Gentoo Foundation
>> # Distributed under the terms of the GNU General Public License v2
>> # $Header: /var/cvsroot/gentoo-x86/app-forensics/memdump/memdump-1.0.1.ebuild,v 1.1 2009/01/04 23:45:43 patrick Exp $
>>
>> DESCRIPTION="Simple memory dumper for UNIX-Like systems"
>> HOMEPAGE="http://www.porcupine.org/forensics"
>> SRC_URI="http://www.porcupine.org/forensics/${PN}-1.01.tar.gz"
>                                                    ~~~~

Missing MY_PV I presume?

>> LICENSE="IBM"
>> SLOT="0"
>> KEYWORDS="~amd64 ~ppc ~x86"
>> DEPEND="sys-apps/sed
>>       sys-apps/grep"
>> RDEPEND="virtual/libc"
>  ^^^^^^^^^^^^^^^^^^^^^^

Useless deps which are already in @system?

>
>> IUSE=""
>>
>>
>> S=${WORKDIR}/${PN}-1.01
>                     ~~~~

Quotes and ${MY_PV} missing?

>> src_compile() {
>>       cd ${S}/memdump-1.01
>          "    "        ~~~~

Quotes, and ${PN}-${MY_PV} ?
Although, should this even be required since ${S} is already set correctly?
Does the tarball have a folder inside a folder?

>>               einfo "testing"
>>               if [ "`./memdump -s 344 | wc -c`" = "344" ];
>>               then
>>                       einfo "passed test"
>>               else
>>                       die "failed test"
>>               fi

Here, why not use

einfo "testing"
[ "`./memdump -s 344 | wc -c`" = "344" ] || die "failed test"
einfo "passed test"


-- 
~Nirbheek Chauhan