Re: [gentoo-dev] Re: gentoo-x86 commit in app-forensics/memdump: memdump-1.0.1.ebuild ChangeLog

[Peter Volkov]

Daniel, answering you in this mail... Yes, probably sometimes we have to
discuss basic things in this mailing list but since developers do this
basic errors we have to. Technical problems in our portage tree are
perfectly valid for this mailing list.

В Пнд, 05/01/2009 в 13:55 +0530, Nirbheek Chauhan пишет:
> >> SRC_URI="http://www.porcupine.org/forensics/${PN}-1.01.tar.gz"                                                    ~~~~
>
> Missing MY_PV I presume?

Hardcoded version makes version bumps harder. I'm not sure why ebuild
was versioned differently from tarbal but yes, in this case it's better
to use versionator eclass define PV.

> >> RDEPEND="virtual/libc"
> >  ^^^^^^^^^^^^^^^^^^^^^^
>
> Useless deps which are already in @system?

Dependency on libc is completely useless since every usable system have
C library.

> >> S=${WORKDIR}/${PN}-1.01
> >                     ~~~~
>
> Quotes and ${MY_PV} missing?

You don't need quotes in assignments. It hardcoded version again.

> >> src_compile() {
> >>       cd ${S}/memdump-1.01
> >          "    "        ~~~~
>
> Quotes, and ${PN}-${MY_PV} ?
> Although, should this even be required since ${S} is already set correctly?

src_compile initial working directory is S so this line could (and
should) be just dropped.

> >>               einfo "testing"
> >>               if [ "`./memdump -s 344 | wc -c`" = "344" ];
> >>               then
> >>                       einfo "passed test"
> >>               else
> >>                       die "failed test"
> >>               fi
>
> Here, why not use
>
> einfo "testing"
> [ "`./memdump -s 344 | wc -c`" = "344" ] || die "failed test"
> einfo "passed test"

Yup. It's shorter and does same thing.

-- 
Peter.