Gentoo Archives: gentoo-dev

From: "Justin Lecher (jlec)" <jlec@g.o>
To: gentoo-dev@l.g.o
Cc: qa@g.o
Subject: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ###
Date: Mon, 28 Dec 2015 14:29:16
Message-Id: 56814725.6080807@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ### by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 28/12/15 15:24, Michał Górny wrote:
5 > Dnia 28 grudnia 2015 09:43:51 CET, Justin Lecher <jlec@g.o>
6 > napisał(a):
7 >> Signed-off-by: Justin Lecher <jlec@g.o> ---
8 >> eclass/check-reqs.eclass | 2 +- 1 file changed, 1 insertion(+), 1
9 >> deletion(-)
10 >>
11 >> diff --git a/eclass/check-reqs.eclass b/eclass/check-reqs.eclass
12 >> index 138bfec..a32f8f8 100644 --- a/eclass/check-reqs.eclass +++
13 >> b/eclass/check-reqs.eclass @@ -306,7 +306,7 @@ check-reqs_disk()
14 >> { ${size} \ "disk space at \"${path}\""
15 >>
16 >> - space_megs=$(df -Pm "${1}" 2>/dev/null | awk 'FNR == 2 {print
17 >> $4}') + space_megs=$(df -P -B 1048576 "${1}" 2>/dev/null | awk
18 >> 'FNR == 2 {print $4}')
19 >
20 > I don't want to spoil the party but '-B' doesn't seem portable. I
21 > don't see that option in FreeBSD man page.
22
23 The source code says
24
25
26 case 'm': /* obsolescent, exists for BSD compatibility */
27
28
29 So it might silently go away. Let me have a look at the BSD sources.
30 -----BEGIN PGP SIGNATURE-----
31 Version: GnuPG/MacGPG2 v2.0
32
33 iQJ8BAEBCgBmBQJWgUclXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
34 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
35 OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiiUgP/itabhl/43o8fY79y/cuZuRW
36 xmvQirepGlHrqVZvgOGiBxyK2q0wpVhrsgHe/hwkK/lV8NA+C0eOIUW2wlwLiyEN
37 T6UavwPFdoZ4YgNuj9m8ZCNbZVrJUyEFP01RUWuHyEah6MFBg+D8Jtl8vWNlzZKm
38 W8z3KPDTrDhpcg8i+r9D915RARpo9wraTc/LvK8QXF51YuBcn1MWsRjd50g2FQiu
39 R6Epylw7EmAL4AT9bhx7skdBS2z5GRHJQFEObYqtxve0PDdXOvw8SOcxwcqQXCv2
40 ZCEuVCURfOlOOVdL1mgfIJa/h1FMO3n1NjrZXFFZtVNs1T3sYm9/lyYjGuYQIFP3
41 ITkIVPBunjgbmG+wNRFOonNRDnxY0Y8F0AiaDNi07WpbkAoo52oHz9gWL/hsdhDd
42 vfH074JoIVtoXS6yeaESPSwOlurQ30bwhpAz7xzWLW8sWopyR+sGkuW7AQ9PkmZc
43 mwVX6ZIWBdZ6Zk5Ae7UNi3Lc3akSrz4GkiAlbLmxg946BMrTfJFIPBFvR82TkkNw
44 +mRPJUPuiCWDDDyDKNCpGb/YQB8kjkiWHZkr1Id7PLhIIDkeuccVqvEvzTNU22pk
45 DdQkUt9L69FxTE8OtskEDueaINaBMtBpGpPh5K+arsKUt85jIX4oM25IXau8HAWx
46 mDTncoD6QRn2dNXuf5gx
47 =O924
48 -----END PGP SIGNATURE-----

Replies