Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o, "Justin Lecher (jlec)" <jlec@g.o>
Cc: qa@g.o
Subject: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ###
Date: Mon, 28 Dec 2015 14:35:18
Message-Id: 8109CFB6-B300-448B-BA98-E7FA2F954757@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ### by "Justin Lecher (jlec)"
1 Dnia 28 grudnia 2015 15:28:53 CET, "Justin Lecher (jlec)" <jlec@g.o> napisał(a):
2 >-----BEGIN PGP SIGNED MESSAGE-----
3 >Hash: SHA512
4 >
5 >On 28/12/15 15:24, Michał Górny wrote:
6 >> Dnia 28 grudnia 2015 09:43:51 CET, Justin Lecher <jlec@g.o>
7 >> napisał(a):
8 >>> Signed-off-by: Justin Lecher <jlec@g.o> ---
9 >>> eclass/check-reqs.eclass | 2 +- 1 file changed, 1 insertion(+), 1
10 >>> deletion(-)
11 >>>
12 >>> diff --git a/eclass/check-reqs.eclass b/eclass/check-reqs.eclass
13 >>> index 138bfec..a32f8f8 100644 --- a/eclass/check-reqs.eclass +++
14 >>> b/eclass/check-reqs.eclass @@ -306,7 +306,7 @@ check-reqs_disk()
15 >>> { ${size} \ "disk space at \"${path}\""
16 >>>
17 >>> - space_megs=$(df -Pm "${1}" 2>/dev/null | awk 'FNR == 2 {print
18 >>> $4}') + space_megs=$(df -P -B 1048576 "${1}" 2>/dev/null | awk
19 >>> 'FNR == 2 {print $4}')
20 >>
21 >> I don't want to spoil the party but '-B' doesn't seem portable. I
22 >> don't see that option in FreeBSD man page.
23 >
24 >The source code says
25 >
26 >
27 >case 'm': /* obsolescent, exists for BSD compatibility */
28 >
29 >
30 >So it might silently go away. Let me have a look at the BSD sources.
31
32 POSIX gives you '-k -P' only, so you should probably stick to that.
33
34 >-----BEGIN PGP SIGNATURE-----
35 >Version: GnuPG/MacGPG2 v2.0
36 >
37 >iQJ8BAEBCgBmBQJWgUclXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
38 >ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
39 >OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiiUgP/itabhl/43o8fY79y/cuZuRW
40 >xmvQirepGlHrqVZvgOGiBxyK2q0wpVhrsgHe/hwkK/lV8NA+C0eOIUW2wlwLiyEN
41 >T6UavwPFdoZ4YgNuj9m8ZCNbZVrJUyEFP01RUWuHyEah6MFBg+D8Jtl8vWNlzZKm
42 >W8z3KPDTrDhpcg8i+r9D915RARpo9wraTc/LvK8QXF51YuBcn1MWsRjd50g2FQiu
43 >R6Epylw7EmAL4AT9bhx7skdBS2z5GRHJQFEObYqtxve0PDdXOvw8SOcxwcqQXCv2
44 >ZCEuVCURfOlOOVdL1mgfIJa/h1FMO3n1NjrZXFFZtVNs1T3sYm9/lyYjGuYQIFP3
45 >ITkIVPBunjgbmG+wNRFOonNRDnxY0Y8F0AiaDNi07WpbkAoo52oHz9gWL/hsdhDd
46 >vfH074JoIVtoXS6yeaESPSwOlurQ30bwhpAz7xzWLW8sWopyR+sGkuW7AQ9PkmZc
47 >mwVX6ZIWBdZ6Zk5Ae7UNi3Lc3akSrz4GkiAlbLmxg946BMrTfJFIPBFvR82TkkNw
48 >+mRPJUPuiCWDDDyDKNCpGb/YQB8kjkiWHZkr1Id7PLhIIDkeuccVqvEvzTNU22pk
49 >DdQkUt9L69FxTE8OtskEDueaINaBMtBpGpPh5K+arsKUt85jIX4oM25IXau8HAWx
50 >mDTncoD6QRn2dNXuf5gx
51 >=O924
52 >-----END PGP SIGNATURE-----
53
54
55 --
56 Best regards,
57 Michał Górny (by phone)

Replies

Subject Author
[gentoo-dev] [PATCH] Replace df -m with df -k Justin Lecher <jlec@g.o>