| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 14/08/15 07:16 AM, hasufell wrote: |
| 5 |
> On 08/14/2015 01:10 PM, Andrew Savchenko wrote: |
| 6 |
>> On Fri, 14 Aug 2015 02:11:09 -0700 Daniel Campbell (zlg) |
| 7 |
>> wrote: |
| 8 |
>>> I honestly don't see the point of this when `git log` or even |
| 9 |
>>> `git diff` or standard `diff` will tell you if what's in your |
| 10 |
>>> overlay differs from the source. With some bash magic it |
| 11 |
>>> could even be automated. The point of that 'feature' is to |
| 12 |
>>> see what, if anything, has changed between one's overlay and |
| 13 |
>>> Gentoo's running tree. A diff would not only be able to tell |
| 14 |
>>> you *if* anything changed, but also *what*, without adding |
| 15 |
>>> around 5-7 extra bytes per ebuild. Sure, it's only bytes, but |
| 16 |
>>> when multiplied against the number of ebuilds we have, it can |
| 17 |
>>> make a few hundred KB difference. When expanded, that number |
| 18 |
>>> multiplies. Is it worth adding this extra bloat to something |
| 19 |
>>> that a standard utility can expose better than a hash? |
| 20 |
>> |
| 21 |
>> Agree here. Also I don't like the idea of post-modifying |
| 22 |
>> content of signed commits: files developers committed to the |
| 23 |
>> tree should be the same users get. As a side effect this will |
| 24 |
>> simplify tree consistency checks and forensics. |
| 25 |
>> |
| 26 |
> |
| 27 |
> The files are already modified (e.g. Manifest) for rsync, so |
| 28 |
> this arguments becomes a moot point. |
| 29 |
> |
| 30 |
> |
| 31 |
|
| 32 |
|
| 33 |
I think it'd also be handy, in terms of debugging rsync's gone awry |
| 34 |
(especially in the case of unofficial rsync mirrors) if the ebuilds |
| 35 |
contained the commit-id; it'd provide a more simple way to check |
| 36 |
where in git history this particular ebuild was committed. I'm |
| 37 |
thinking especially in cases where for whatever reason an rsync |
| 38 |
doesn't synchronize the entire repo. |
| 39 |
|
| 40 |
That said, since $Id$ is apparently not going to be a commit-id that |
| 41 |
can be checked quickly by 'git show' or searched for in 'git log', |
| 42 |
I'm not sure if that makes it as easy to check as I'm imagining... |
| 43 |
|
| 44 |
-----BEGIN PGP SIGNATURE----- |
| 45 |
Version: GnuPG v2 |
| 46 |
|
| 47 |
iF4EAREIAAYFAlXN/DUACgkQAJxUfCtlWe0TugEAr+eKeiFcPrNLfbR2vrN06U7E |
| 48 |
cldl+tb+rjJZT7NMZ3UBANV4x8b1fj4NQu+DO38bYKCtZ7NZdNWALUXiDxYSf9mO |
| 49 |
=c00L |
| 50 |
-----END PGP SIGNATURE----- |
Archives