| 1 |
On 08/14/2015 01:10 PM, Andrew Savchenko wrote: |
| 2 |
> On Fri, 14 Aug 2015 02:11:09 -0700 Daniel Campbell (zlg) wrote: |
| 3 |
>> I honestly don't see the point of this when `git log` or even `git |
| 4 |
>> diff` or standard `diff` will tell you if what's in your overlay |
| 5 |
>> differs from the source. With some bash magic it could even be |
| 6 |
>> automated. The point of that 'feature' is to see what, if anything, |
| 7 |
>> has changed between one's overlay and Gentoo's running tree. A diff |
| 8 |
>> would not only be able to tell you *if* anything changed, but also |
| 9 |
>> *what*, without adding around 5-7 extra bytes per ebuild. Sure, it's |
| 10 |
>> only bytes, but when multiplied against the number of ebuilds we have, |
| 11 |
>> it can make a few hundred KB difference. When expanded, that number |
| 12 |
>> multiplies. Is it worth adding this extra bloat to something that a |
| 13 |
>> standard utility can expose better than a hash? |
| 14 |
> |
| 15 |
> Agree here. Also I don't like the idea of post-modifying content of |
| 16 |
> signed commits: files developers committed to the tree should be |
| 17 |
> the same users get. As a side effect this will simplify tree |
| 18 |
> consistency checks and forensics. |
| 19 |
> |
| 20 |
|
| 21 |
The files are already modified (e.g. Manifest) for rsync, so this |
| 22 |
arguments becomes a moot point. |
Archives