| 1 |
On Wed, 28 Aug 2013 16:37:44 +0200 |
| 2 |
hasufell <hasufell@g.o> wrote: |
| 3 |
|
| 4 |
From a fairly quick review: |
| 5 |
|
| 6 |
> smpeg2: https://bugs.gentoo.org/show_bug.cgi?id=481792 |
| 7 |
|
| 8 |
https://481792.bugs.gentoo.org/attachment.cgi?id=356542 |
| 9 |
|
| 10 |
What if what the debug flag does is changed in the future? |
| 11 |
|
| 12 |
I'd suggest to drop the flag and patch the build system. |
| 13 |
|
| 14 |
Other than that I don't see any questionable matters. The rest of my |
| 15 |
suggestions would be bikeshedding as you say, because it depends on |
| 16 |
your own idea of it; eg. a lot of dependencies have no slots, etc... |
| 17 |
|
| 18 |
Thank you for bringing this to the Portage tree, it has a huge demand. |
| 19 |
|
| 20 |
-- |
| 21 |
With kind regards, |
| 22 |
|
| 23 |
Tom Wijsman (TomWij) |
| 24 |
Gentoo Developer |
| 25 |
|
| 26 |
E-mail address : TomWij@g.o |
| 27 |
GPG Public Key : 6D34E57D |
| 28 |
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D |
Archives