Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: William Hubbs <williamh@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2] go-module.eclass: deprecate EGO_SUM and call ego instead of go
Date: Fri, 04 Mar 2022 00:01:56
Message-Id: 9D1CAC73-AAB3-4F93-AC13-A53210EBA132@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH v2] go-module.eclass: deprecate EGO_SUM and call ego instead of go by William Hubbs
1 > On 4 Mar 2022, at 00:00, William Hubbs <williamh@g.o> wrote:
2 >
3 > On Wed, Mar 02, 2022 at 09:32:14PM +0500, Anna Vyalkova wrote:
4 >> On 2022-03-01 15:55, William Hubbs wrote:
5 >>> I am willing to flag EGO_SUM as deprecated if a variable can be flagged
6 >>> as deprecated; that is what I'm looking up now.
7 >>
8 >> EGO_SUM is often the only choice for overlays, so consider not
9 >> deprecating it.
10 >
11 > EGO_SUM does not work for large SRC_URI; that is the reason it is
12 > being deprecated.
13 >
14 > Also, my understanding is we do not normally keep code around
15 > if that code's only purpose is to support overlays.
16
17 I don't think there's a need to rip it out given we know it can be quite
18 useful there though, right?
19
20 It's not actively harming anything to just keep the small amount of code there.
21
22 I think it's quite a nice convenience option (in fact, for ::gentoo too), where
23 EGO_SUM isn't huge. But I admit this isn't that common.
24
25 As for the series: as per commits on IRC: fine to compromise on you
26 removing it now, but please do in two separate commits so it's more
27 obvious in the git history. But that's notwithstanding possibly keeping it
28 for overlays.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies