Re: [gentoo-dev] [PATCH v2] go-module.eclass: deprecate EGO_SUM and call ego instead of go

[William Hubbs]

On Fri, Mar 04, 2022 at 12:01:42AM +0000, Sam James wrote:
>
>
> > On 4 Mar 2022, at 00:00, William Hubbs <williamh@g.o> wrote:
> >
> > On Wed, Mar 02, 2022 at 09:32:14PM +0500, Anna Vyalkova wrote:
> >> On 2022-03-01 15:55, William Hubbs wrote:
> >>> I am willing to flag EGO_SUM as deprecated if a variable can be flagged
> >>> as deprecated; that is what I'm looking up now.
> >>
> >> EGO_SUM is often the only choice for overlays, so consider not
> >> deprecating it.
> >
> > EGO_SUM does not work for large SRC_URI; that is the reason it is
> > being deprecated.
> >
> > Also, my understanding is we do not normally keep code around
> > if that code's only purpose is to support overlays.
>
> I don't think there's a need to rip it out given we know it can be quite
> useful there though, right?
>
> It's not actively harming anything to just keep the small amount of code there.

Sure, it may not be harmful to keep it there, but using it in the main
tree isn't going to be a thing. 

> I think it's quite a nice convenience option (in fact, for ::gentoo too), where
> EGO_SUM isn't huge. But I admit this isn't that common.

Another thing to consider is that the bulk of the code in the eclass is
for handling EGO_SUM, so if I can remove it, ultimately, it will mean less code to maintain.

I will post a separate patch which I will not merge at this point to
show what I'm talking about.

Thanks,

William