| 1 |
On Tue, 12 Oct 2010 22:09:06 +0200 |
| 2 |
Dirkjan Ochtman <djc@g.o> wrote: |
| 3 |
|
| 4 |
> On Fri, Oct 1, 2010 at 15:07, Peter Volkov <pva@g.o> wrote: |
| 5 |
> > [a very thorough review of the openvpn ebuild] |
| 6 |
> |
| 7 |
> Thanks for reviewing, I've fixed most of the issues. |
| 8 |
> |
| 9 |
> >> if [[ -n $(ls /etc/openvpn/*/local.conf 2>/dev/null) ]] ; |
| 10 |
> >> then |
| 11 |
> > |
| 12 |
> > I'd suggested [ -e /etc/openvpn/*/local.conf ] here, but probably |
| 13 |
> > there are better alternatives. Also ${ROOT} is missed here. |
| 14 |
> |
| 15 |
> I've put ${ROOT} in, are there no better alternatives? I don't think |
| 16 |
> anyone mentioned any. |
| 17 |
|
| 18 |
for foo in ${ROOT}/etc/openvpn/*/local.conf; do |
| 19 |
[ -e ${foo} ] && bar ${foo} |
| 20 |
done |
| 21 |
|
| 22 |
If no ${ROOT}/etc/openvpn/*/local.conf is found, it returns the exact |
| 23 |
string; which doesn't exist so Nothing Happens. |
| 24 |
|
| 25 |
|
| 26 |
jer |
Archives