Archives
Archives
| From: | Dirkjan Ochtman <djc@g.o> | ||
|---|---|---|---|
| To: | Peter Volkov <pva@g.o> | ||
| Cc: | gentoo-dev@l.g.o | ||
| Subject: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild | ||
| Date: | Tue, 12 Oct 2010 20:09:57 | ||
| Message-Id: | AANLkTik=kMxt60oJ_9e7eYYEq-cN2XJy7dZqRD00PwU1@mail.gmail.com | ||
| In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild by Peter Volkov |
||
| 1 | On Fri, Oct 1, 2010 at 15:07, Peter Volkov <pva@g.o> wrote: |
| 2 | > [a very thorough review of the openvpn ebuild] |
| 3 | |
| 4 | Thanks for reviewing, I've fixed most of the issues. |
| 5 | |
| 6 | >> if [[ -n $(ls /etc/openvpn/*/local.conf 2>/dev/null) ]] ; then |
| 7 | > |
| 8 | > I'd suggested [ -e /etc/openvpn/*/local.conf ] here, but probably there |
| 9 | > are better alternatives. Also ${ROOT} is missed here. |
| 10 | |
| 11 | I've put ${ROOT} in, are there no better alternatives? I don't think |
| 12 | anyone mentioned any. |
| 13 | |
| 14 | Cheers, |
| 15 | |
| 16 | Dirkjan |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild | Mike Frysinger <vapier@g.o> |
| Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild | Jeroen Roovers <jer@g.o> |
| Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/openvpn: ChangeLog openvpn-2.1.3.ebuild | Mike Frysinger <vapier@g.o> |