Re: [gentoo-dev] Re: Apply patch depending on USE flag

[Georgi Georgiev]

maillog: 29/04/2004-22:27:22(-0400): Brett I. Holcomb types
> For the sake of one who is doing ebuilds - why is the first form
> preferred?  I'm curious.  I'm working on revising an ebuild now that has
> the bad form.

Related to the question: I really hate it when ebuild start printing out use
flags here and there, because of the 

if use foo; then... 
use foo && ...

syntax. I guess [ "`use foo`" ] is at least cleaner in respect to output. It
would be great if "use" did not print anything, or if there was an alternate.
Right now, one would have to add ">/dev/null" after "use", if they want to keep
the output clean. Is the reason why using the output of "use foo" is not
preferred, because "use" will soon become silent?

> Thanks.
>
> On Thu, 29 Apr 2004, Mike Frysinger wrote:
>
> > On Thursday 29 April 2004 03:33 pm, Michael Sterrett -Mr. Bones.- wrote:
> > > On Thu, 29 Apr 2004, Lars Strojny wrote:
> > > > On Thu, 29 Apr 2004 18:20:48 +0100
> > > > Tom Wesley <tom.wesley@××××××××.com> wrote:
> > > > > You can
> > > > >
> > > > >         if use nntp; then
> > > > >             epatch ${DISTDIR}/${nntp_patch}
> > > > >         fi
> > > >
> > > > I think
> > > > if [ "`use nntp`" ] ; then
> > > > is more elegant ;)
> > >
> > > Between the two, the first example is preferred.
> >
> > and by prefered he means 'do not use the following syntax anymore in ebuilds':
> > [ `use nntp` ]
> > [ "`use nntp`" ]
> > [ -z "`use nntp`" ]
> > [ -n "`use nntp`" ]

-- 
\    Georgi Georgiev   \  To love is good, love being difficult.       \
/     chutz@×××.net    /                                               /
\   [phone]   \                                               \

--
gentoo-dev@g.o mailing list