| 1 |
On 05/04/2016 10:52 AM, Sam Jorna wrote: |
| 2 |
> On Wed, May 04, 2016 at 10:00:05AM +0200, Ulrich Mueller wrote: |
| 3 |
>>>>>>> On Wed, 4 May 2016, Austin English wrote: |
| 4 |
>> |
| 5 |
>>>> Your list of affected packages obtained with "git grep" in the |
| 6 |
>>>> Portage tree will not be complete, since the command won't catch |
| 7 |
>>>> any init scripts installed from elsewhere. You should look for the |
| 8 |
>>>> set of installed files instead. |
| 9 |
>> |
| 10 |
>>> How is that relevant here at all? I'm cleaning up portage installed |
| 11 |
>>> init scripts, [...] |
| 12 |
>> |
| 13 |
>> You are cleaning up only those init scripts that are installed from |
| 14 |
>> FILESDIR, but you will miss the ones that are installed from a file |
| 15 |
>> in SRC_URI. |
| 16 |
> |
| 17 |
> Perhaps an alternate way to do it would be to have a QA check look at |
| 18 |
> any files installed to ${D}etc/init.d/ and throw a warning if their |
| 19 |
> shebang is "#!/sbin/runscript" |
| 20 |
> |
| 21 |
|
| 22 |
A repoman check is a much saner approach, I'm not convinced there is |
| 23 |
sufficient need for this change to begin with, in particular to start |
| 24 |
touching a wide range of packages. Breaking backwards compatibility in |
| 25 |
any way should have a darn good reason, and I haven't seen one yet |
| 26 |
|
| 27 |
|
| 28 |
-- |
| 29 |
Kristian Fiskerstrand |
| 30 |
OpenPGP certificate reachable at hkp://pool.sks-keyservers.net |
| 31 |
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3 |
Archives