Gentoo Archives: gentoo-dev

From: Peter Alfredsen <loki_val@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] New eclass: go-mono.eclass
Date: Sat, 17 Jan 2009 12:44:55
Message-Id: 20090117134138.6e0dbe34@gentoo.org
In Reply to: Re: [gentoo-dev] New eclass: go-mono.eclass by "Petteri Räty"
1 On Sat, 17 Jan 2009 14:04:28 +0200
2 Petteri Räty <betelgeuse@g.o> wrote:
3
4 > # @FUNCTION: go-mono_src_unpack
5 > # @DESCRIPTION: Runs default()
6 > go-mono_src_unpack() {
7 > default
8 > }
9 >
10 > What's the point? The ones from base.eclass should be doing the same
11 > thing as the default ones any way.
12 >
13 > The same goes for src_compile.
14
15 To make sure we know what we are getting and don't have to go searching
16 through more than one eclass to see exactly what a function does.
17
18 > local COMMONDOC=( AUTHORS ChangeLog README TODO )
19 >
20 > I wouldn't write local variables with capital letters.
21
22 Sure, we can paint the bikeshed green :-)
23
24 /PA