Archives
Archives
| From: | Kristian Fiskerstrand <k_f@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] Dealing with GitHub Pull Requests the easy way | ||
| Date: | Wed, 19 Oct 2016 12:15:29 | ||
| Message-Id: | 53cb00fe-ecfd-a459-c6fd-009fe272acda@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] Dealing with GitHub Pull Requests the easy way by Matthew Thode |
||
| 1 | On 10/19/2016 02:13 PM, Matthew Thode wrote: |
| 2 | > On 10/19/2016 04:10 AM, Ulrich Mueller wrote: |
| 3 | >> Maybe I have missed something, but why would one use --signoff for |
| 4 | >> a Gentoo commit? |
| 5 | > |
| 6 | > Personally I use it as 'I sign off on the Author's work'. I suppose the |
| 7 | > commit itself is good enough for this but I personally prefer verbosity. |
| 8 | > It also calls out that it wasn't my work. |
| 9 | > |
| 10 | |
| 11 | This sounds more like a reviewed by or acked by? |
| 12 | |
| 13 | |
| 14 | -- |
| 15 | Kristian Fiskerstrand |
| 16 | OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net |
| 17 | fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3 |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] Dealing with GitHub Pull Requests the easy way | Matthew Thode <prometheanfire@g.o> |
| Re: [gentoo-dev] Dealing with GitHub Pull Requests the easy way | Kent Fredric <kentnl@g.o> |