Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/)
Date: Sun, 09 Aug 2015 15:43:54
Message-Id: CAJ0EP43DoOTFvDDvb+npr23t_NWguqOk8fJvK9bni3YptzaTVQ@mail.gmail.com
In Reply to: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/) by hasufell
1 On Sun, Aug 9, 2015 at 11:30 AM, hasufell <hasufell@g.o> wrote:
2 > On 08/09/2015 05:19 PM, Tobias Klausmann wrote:
3 >> Hi!
4 >>
5 >> On Sun, 09 Aug 2015, Sven Vermeulen wrote:
6 >>
7 >>> On Sun, Aug 09, 2015 at 04:43:36PM +0200, Dirkjan Ochtman wrote:
8 >>>>> I think "X-Gentoo-Bug: 557022" also makes the job easier for tools that
9 >>>>> parse commit messages.
10 >>>>
11 >>>> I don't. Just the "bug " prefix should be fine for almost all
12 >>>> purposes, even for tools.
13 >>>
14 >>> I'm pretty sure the majority of developers don't care that one developer
15 >>> uses "X-Gentoo-Bug" and another just adds it to the commit title.
16 >>>
17 >>> I like /guidelines/ in the sense that, if I don't know something, I can look
18 >>> it up. But don't make it mandatory until we start depending on it (for
19 >>> instance, when we would automate stuff based on the content of the commit
20 >>> message).
21 >>
22 >> I'd just go with "Gentoo-Bug". The X- is pointless since it was
23 >> for eXtending Email-Headers. And what we do is only linked in
24 >> style.
25 >>
26 >
27 > I'd be fine with that and add a reference to the kernel guideline [0] to
28 > the wiki as well, so that it is clear that we also allow/use Acked-by,
29 > Reviewed-by, Suggested-by and whatnot.
30 >
31 > I'll wait for more ++ though.
32
33 I like Gentoo-Bug. Much nicer without the X-.

Replies