Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/)
Date: Sun, 09 Aug 2015 15:30:46
Message-Id: 55C77214.107@gentoo.org
In Reply to: Re: [gentoo-dev] Referencing bug reports in git (WAS: Re: [gentoo-commits] repo/gentoo:master commit in: sci-libs/opencascade/) by Tobias Klausmann
1 On 08/09/2015 05:19 PM, Tobias Klausmann wrote:
2 > Hi!
3 >
4 > On Sun, 09 Aug 2015, Sven Vermeulen wrote:
5 >
6 >> On Sun, Aug 09, 2015 at 04:43:36PM +0200, Dirkjan Ochtman wrote:
7 >>>> I think "X-Gentoo-Bug: 557022" also makes the job easier for tools that
8 >>>> parse commit messages.
9 >>>
10 >>> I don't. Just the "bug " prefix should be fine for almost all
11 >>> purposes, even for tools.
12 >>
13 >> I'm pretty sure the majority of developers don't care that one developer
14 >> uses "X-Gentoo-Bug" and another just adds it to the commit title.
15 >>
16 >> I like /guidelines/ in the sense that, if I don't know something, I can look
17 >> it up. But don't make it mandatory until we start depending on it (for
18 >> instance, when we would automate stuff based on the content of the commit
19 >> message).
20 >
21 > I'd just go with "Gentoo-Bug". The X- is pointless since it was
22 > for eXtending Email-Headers. And what we do is only linked in
23 > style.
24 >
25
26 I'd be fine with that and add a reference to the kernel guideline [0] to
27 the wiki as well, so that it is clear that we also allow/use Acked-by,
28 Reviewed-by, Suggested-by and whatnot.
29
30 I'll wait for more ++ though.
31
32
33 [0] https://www.kernel.org/doc/Documentation/SubmittingPatches

Replies