Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | "Michał Górny" <mgorny@g.o> | ||
| Cc: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH 1/5] out-of-source-utils.eclass: New utility eclass | ||
| Date: | Mon, 02 Jan 2023 09:25:23 | ||
| Message-Id: | ubknhe1ai@gentoo.org | ||
| In Reply to: | [gentoo-dev] [PATCH 1/5] out-of-source-utils.eclass: New utility eclass by "Michał Górny" |
||
| 1 | >>>>> On Sun, 01 Jan 2023, Michał Górny wrote: |
| 2 | |
| 3 | > +case ${EAPI} in |
| 4 | > + 6|7|8) ;; |
| 5 | > + *) die "${ECLASS}: EAPI ${EAPI} unsupported." |
| 6 | |
| 7 | Are you sure that this will work without the final ;; terminator? |
| 8 | (Bash documentation says that a terminator is mandatory.) |
| 9 | |
| 10 | Apart from that, I'd suggest to use the standard clause as in other |
| 11 | eclasses: |
| 12 | |
| 13 | *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; |
| 14 | |
| 15 | > +esac |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH 1/5] out-of-source-utils.eclass: New utility eclass | "Michał Górny" <mgorny@g.o> |