| 1 |
On Mon, 2023-01-02 at 10:25 +0100, Ulrich Mueller wrote: |
| 2 |
> > > > > > On Sun, 01 Jan 2023, Michał Górny wrote: |
| 3 |
> |
| 4 |
> > +case ${EAPI} in |
| 5 |
> > + 6|7|8) ;; |
| 6 |
> > + *) die "${ECLASS}: EAPI ${EAPI} unsupported." |
| 7 |
> |
| 8 |
> Are you sure that this will work without the final ;; terminator? |
| 9 |
> (Bash documentation says that a terminator is mandatory.) |
| 10 |
|
| 11 |
Interesting enough, it does work. |
| 12 |
|
| 13 |
> Apart from that, I'd suggest to use the standard clause as in other |
| 14 |
> eclasses: |
| 15 |
> |
| 16 |
> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; |
| 17 |
> |
| 18 |
|
| 19 |
Actually, this is what app-vim/gentoo-syntax spews by default. I guess |
| 20 |
I need to change it. |
| 21 |
|
| 22 |
Anyway, replaced by your snippet. I suppose it's fine if I don't |
| 23 |
resubmit the batch for this change. |
| 24 |
|
| 25 |
-- |
| 26 |
Best regards, |
| 27 |
Michał Górny |
Archives