Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
Date: Thu, 02 Jan 2020 21:09:07
Message-Id: e90effe4a377ff292f74a1ba97386486c3de76ba.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies by Ulrich Mueller
1 On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
2 > > > > > > On Thu, 02 Jan 2020, Michał Górny wrote:
3 > > --- a/eclass/ruby-ng.eclass
4 > > +++ b/eclass/ruby-ng.eclass
5 > > @@ -137,7 +137,7 @@ ruby_samelib() {
6 > > local res=
7 > > for _ruby_implementation in $(_ruby_get_all_impls); do
8 > > has -${_ruby_implementation} $@ || \
9 > > - res="${res}ruby_targets_${_ruby_implementation}?,"
10 > > + res="${res}ruby_targets_${_ruby_implementation}(-)?,"
11 > > done
12 > >
13 > > echo "[${res%,}]"
14 >
15 > Hadn't we established that ruby_samelib() is dead code, no longer used
16 > since 2010?
17 >
18
19 You did. However, it isn't marked as private API and I'm not the eclass
20 maintainer to take care of removing public API. I have no clue if Ruby
21 project doesn't have some secret overlays using it.
22
23 --
24 Best regards,
25 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies