Gentoo Archives: gentoo-dev

From: Michael 'veremitz' Everitt <gentoo@×××××××.xyz>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
Date: Thu, 02 Jan 2020 21:54:29
Message-Id: 79f54991-acd4-295d-0a3a-25efb392af38@veremit.xyz
In Reply to: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies by "Michał Górny"
On 02/01/20 21:08, Michał Górny wrote:
> On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: >>>>>>> On Thu, 02 Jan 2020, Michał Górny wrote: >>> --- a/eclass/ruby-ng.eclass >>> +++ b/eclass/ruby-ng.eclass >>> @@ -137,7 +137,7 @@ ruby_samelib() { >>> local res= >>> for _ruby_implementation in $(_ruby_get_all_impls); do >>> has -${_ruby_implementation} $@ || \ >>> - res="${res}ruby_targets_${_ruby_implementation}?," >>> + res="${res}ruby_targets_${_ruby_implementation}(-)?," >>> done >>> >>> echo "[${res%,}]" >> Hadn't we established that ruby_samelib() is dead code, no longer used >> since 2010? >> > You did. However, it isn't marked as private API and I'm not the eclass > maintainer to take care of removing public API. I have no clue if Ruby > project doesn't have some secret overlays using it. >
<sarcasm> You can't use QA super-powerz ?! BDFL + sub-BDFL ?! </sarcasm>* * Thought the tags probably worth making explicit

Attachments

File name MIME type
signature.asc application/pgp-signature