Gentoo Archives: gentoo-dev

From: Michael 'veremitz' Everitt <gentoo@×××××××.xyz>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
Date: Thu, 02 Jan 2020 21:54:29
Message-Id: 79f54991-acd4-295d-0a3a-25efb392af38@veremit.xyz
In Reply to: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies by "Michał Górny"
1 On 02/01/20 21:08, Michał Górny wrote:
2 > On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
3 >>>>>>> On Thu, 02 Jan 2020, Michał Górny wrote:
4 >>> --- a/eclass/ruby-ng.eclass
5 >>> +++ b/eclass/ruby-ng.eclass
6 >>> @@ -137,7 +137,7 @@ ruby_samelib() {
7 >>> local res=
8 >>> for _ruby_implementation in $(_ruby_get_all_impls); do
9 >>> has -${_ruby_implementation} $@ || \
10 >>> - res="${res}ruby_targets_${_ruby_implementation}?,"
11 >>> + res="${res}ruby_targets_${_ruby_implementation}(-)?,"
12 >>> done
13 >>>
14 >>> echo "[${res%,}]"
15 >> Hadn't we established that ruby_samelib() is dead code, no longer used
16 >> since 2010?
17 >>
18 > You did. However, it isn't marked as private API and I'm not the eclass
19 > maintainer to take care of removing public API. I have no clue if Ruby
20 > project doesn't have some secret overlays using it.
21 >
22 <sarcasm> You can't use QA super-powerz ?! BDFL + sub-BDFL ?! </sarcasm>*
23
24 * Thought the tags probably worth making explicit

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies