Gentoo Archives: gentoo-dev

From: Kristian Fiskerstrand <k_f@g.o>
To: gentoo-dev@l.g.o, Ulrich Mueller <ulm@g.o>
Subject: eclass committ message verbosity (Was: Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.)
Date: Tue, 06 Feb 2018 14:42:26
Message-Id: 11c10acb-9965-951a-a5e2-56c0189fbbf7@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command. by Ulrich Mueller
1 On 02/06/2018 03:36 PM, Ulrich Mueller wrote:
2 >>>>>> On Tue, 6 Feb 2018, Kristian Fiskerstrand wrote:
3
4
5 >> More generally though, should we start requiring more verbose commit
6 >> messages for eclasses to make it easier to trace changes in our git
7 >> repo directly without reaching out to bugs? At least including
8 >> summaries of the respective bugs as a short description?
9 >
10 > In the concrete example, the bug's summary is "bzr.eclass might need
11 > to use bzr pull's --overwrite-tags flag" which is not much different
12 > from the git commit message.
13
14 Right, this specific commit likely has little more to gain given the
15 summary line. But could easily benefit from some text in body still :)
16
17 But I generally think we can benefit from some more verbosity in our
18 commit messages, in particular for eclasses.
19
20 --
21 Kristian Fiskerstrand
22 OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
23 fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3

Attachments

File name MIME type
signature.asc application/pgp-signature