Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Proposal of accepting arguments to `default` in src_install (and more?) phases in EAPI=5 (for the next council meeting?)
Date: Sat, 12 May 2012 17:58:03
Message-Id: 20398.42099.258387.30470@a1i15.kph.uni-mainz.de
In Reply to: [gentoo-dev] Proposal of accepting arguments to `default` in src_install (and more?) phases in EAPI=5 (for the next council meeting?) by Samuli Suominen
1 >>>>> On Sat, 12 May 2012, Samuli Suominen wrote:
2
3 > Example,
4 > - Package is using autotools.
5 > - The default phase like below works for the package:
6
7 > src_install() {
8 > emake DESTDIR="${D}" install
9 > dodoc README
10 > }
11
12 > So when writing a new ebuild you would only add:
13
14 > DOCS="README"
15
16 > And be done with it. Then the next version of the package needs extra
17 > argument passed to emake install, for example:
18
19 > src_install() {
20 > emake DESTDIR="${D}" init_d_path="/usr/share/doc/${PF}/examples" install
21 > dodoc README
22 > }
23
24 > So you are /forced/ to write entire src_install() while you only want to
25 > append one argument to emake install.
26
27 > The current workaround for this is to use EXTRA_EMAKE from ebuild, but I
28 > find this rather ugly (if not even forbidden by some PMS magic?)
29
30 EXTRA_EMAKE isn't mentioned by the PMS. Do all package managers
31 support this variable? Portage does since 2004 at least.
32
33 > Can we make econf in src_configure, emake in src_compile, and emake
34 > install in src_install accept arguments "$@" in EAPI=5, please?
35
36 I'd rather document EXTRA_EMAKE and EXTRA_ECONF in the spec, either
37 retroactively (in case all package managers support these variables
38 already), or for EAPI 5. It would accomplish the same as your
39 proposal, even without the need to add an explicit src_install
40 function.
41
42 > Relavent bug is http://bugs.gentoo.org/364343
43
44 Ulrich

Replies