Gentoo Archives: gentoo-dev

From: George Shapovalov <george@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnat.eclass
Date: Thu, 27 Sep 2007 07:58:28
Message-Id: 200709270947.14083.george@gentoo.org
In Reply to: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnat.eclass by Donnie Berkholz
1 Thursday, 27. September 2007, Donnie Berkholz Ви написали:
2 > > + if [[ ${profiles[@]} == "${MARKER}*" ]]; then
3 > > + exit
4 >
5 > I'm surprised to see exit called in a function instead of returning
6 > nonzero.
7
8 This exit here indicates not a very usual but a valid situation, - no gnat
9 profile has been activated yet. So, this is not an error, at least not
10 always. But yes, returning a non zero also possible, though testing the
11 result is not that different from testing for a non-zero string, and the
12 latter is not intuitively percieved as an error :).
13
14 George
15 --
16 gentoo-dev@g.o mailing list

Replies