| 1 |
On Thursday 16 August 2012 16:19:44 Michał Górny wrote: |
| 2 |
> --- a/eutils.eclass |
| 3 |
> +++ b/eutils.eclass |
| 4 |
> |
| 5 |
> +# Install all specified <file>s into <directory>. This doesn't modify global |
| 6 |
> +# 'insinto' path. Alike doins, calls 'die' on failure in EAPI 4+; in earlier |
| 7 |
> +# EAPIs, returns false in that case. |
| 8 |
|
| 9 |
i don't really see the point in differentiating here. we have plenty of |
| 10 |
helpers that have always implicitly called die regardless of the EAPI level, |
| 11 |
and it's not like you'd be breaking any existing behavior since no one is |
| 12 |
using this already. and even then, you'd be "breaking" builds that were |
| 13 |
already broken. |
| 14 |
|
| 15 |
> +dointo() { |
| 16 |
> + [[ ${#} -gt 2 ]] || die 'Synopsis: dointo <directory> <file> [...]' |
| 17 |
|
| 18 |
"Usage" is the standard prefix, not "Synopsis" |
| 19 |
|
| 20 |
style wise, {} around #/@/1/2/3/4/5/6/7/8/9/? variables is noise imo |
| 21 |
-mike |
Archives