Re: [gentoo-dev] [PATCH eutils 1/2] Add dointo && newinto.

[Michał Górny]

On Fri, 17 Aug 2012 23:25:10 -0400
Mike Frysinger <vapier@g.o> wrote:

> On Thursday 16 August 2012 16:19:44 Michał Górny wrote:
> > --- a/eutils.eclass
> > +++ b/eutils.eclass
> >
> > +# Install all specified <file>s into <directory>. This doesn't
> > modify global +# 'insinto' path. Alike doins, calls 'die' on
> > failure in EAPI 4+; in earlier +# EAPIs, returns false in that case.
>
> i don't really see the point in differentiating here.  we have plenty
> of helpers that have always implicitly called die regardless of the
> EAPI level, and it's not like you'd be breaking any existing behavior
> since no one is using this already.  and even then, you'd be
> "breaking" builds that were already broken.

Maybe. Alternatively, I could end up doing doins || die || die. It will
work but what's the point?

> > +dointo() {
> > +	[[ ${#} -gt 2 ]] || die 'Synopsis: dointo <directory>
> > <file> [...]'
>
> "Usage" is the standard prefix, not "Synopsis"

Fixed.

-- 
Best regards,
Michał Górny