| 1 |
On Sun, 21 Apr 2013 17:32:26 +0200 |
| 2 |
Tom Wijsman <TomWij@g.o> wrote: |
| 3 |
|
| 4 |
> On Sun, 21 Apr 2013 17:05:49 +0200 |
| 5 |
> Alexis Ballier <aballier@g.o> wrote: |
| 6 |
> |
| 7 |
> > On Sun, 21 Apr 2013 20:53:28 +0800 |
| 8 |
> > Ben de Groot <yngwin@g.o> wrote: |
| 9 |
> > > > |
| 10 |
> > > > PS: btw, some hunks are weird in your commit, a locale issue ? |
| 11 |
> > > > |
| 12 |
> > > |
| 13 |
> > > No, just a line in my vimrc that removes trailing whitespace. |
| 14 |
> > > |
| 15 |
> > |
| 16 |
> > You should probably disable it or remove trailing whitespaces in a |
| 17 |
> > separate commit though. Having functional changes mixed with |
| 18 |
> > whitespace/cosmetics in a single commit makes it hard to read |
| 19 |
> > and understand. |
| 20 |
> |
| 21 |
> You should just convert the commit diff to not include space changes. |
| 22 |
|
| 23 |
How? Sometimes space changes matter a lot... |
| 24 |
|
| 25 |
Alexis. |
Archives