| 1 |
On Sun, 21 Apr 2013 17:05:49 +0200 |
| 2 |
Alexis Ballier <aballier@g.o> wrote: |
| 3 |
|
| 4 |
> On Sun, 21 Apr 2013 20:53:28 +0800 |
| 5 |
> Ben de Groot <yngwin@g.o> wrote: |
| 6 |
> > > |
| 7 |
> > > PS: btw, some hunks are weird in your commit, a locale issue ? |
| 8 |
> > > |
| 9 |
> > |
| 10 |
> > No, just a line in my vimrc that removes trailing whitespace. |
| 11 |
> > |
| 12 |
> |
| 13 |
> You should probably disable it or remove trailing whitespaces in a |
| 14 |
> separate commit though. Having functional changes mixed with |
| 15 |
> whitespace/cosmetics in a single commit makes it hard to read |
| 16 |
> and understand. |
| 17 |
|
| 18 |
You should just convert the commit diff to not include space changes. |
| 19 |
|
| 20 |
> [This is really a nitpick, no need to have a debate, it's only a |
| 21 |
> suggestion ;)] |
| 22 |
|
| 23 |
[There are two sides to a debate; so, the nitpick goes both ways. ;)] |
| 24 |
|
| 25 |
-- |
| 26 |
With kind regards, |
| 27 |
|
| 28 |
Tom Wijsman (TomWij) |
| 29 |
Gentoo Developer |
| 30 |
|
| 31 |
E-mail address : TomWij@g.o |
| 32 |
GPG Public Key : 6D34E57D |
| 33 |
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D |
Archives