Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Patrice Clement <monsieurp@g.o>
Cc: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-qt/qtmultimedia/
Date: Mon, 18 Apr 2016 15:51:22
Message-Id: 20160418174708.082aa6fb.mgorny@gentoo.org
1 On Mon, 18 Apr 2016 08:13:34 +0000 (UTC)
2 "Patrice Clement" <monsieurp@g.o> wrote:
3
4 > commit: d43acba31bb5d4f07e59479cd5728abc9367a9ca
5 > Author: Patrice Clement <monsieurp <AT> gentoo <DOT> org>
6 > AuthorDate: Mon Apr 18 06:46:09 2016 +0000
7 > Commit: Patrice Clement <monsieurp <AT> gentoo <DOT> org>
8 > CommitDate: Mon Apr 18 07:58:25 2016 +0000
9 > URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d43acba3
10 >
11 > dev-qt/qtmultimedia: Fix metadata.xml file.
12 >
13 > Package-Manager: portage-2.2.26
14 >
15 > dev-qt/qtmultimedia/metadata.xml | 4 ++--
16 > 1 file changed, 2 insertions(+), 2 deletions(-)
17 >
18 > diff --git a/dev-qt/qtmultimedia/metadata.xml b/dev-qt/qtmultimedia/metadata.xml
19 > index c0d6a4e..ab0a181 100644
20 > --- a/dev-qt/qtmultimedia/metadata.xml
21 > +++ b/dev-qt/qtmultimedia/metadata.xml
22 > @@ -9,8 +9,8 @@
23 > <flag name="exceptions">Add support for exceptions - like catching them
24 > inside the event loop (recommended by upstream)</flag>
25 > <flag name="gles2">Enable EGL/GLES2 integration</flag>
26 > - <flag name="gstreamer">Enable audio support via <pkg>media-libs/gstreamer:1.0</pkg></flag>
27 > - <flag name="gstreamer010">Enable audio support via <pkg>media-libs/gstreamer:0.10</pkg></flag>
28 > + <flag name="gstreamer">Enable audio support via <pkg>media-libs/gstreamer-1.0</pkg></flag>
29 > + <flag name="gstreamer010">Enable audio support via <pkg>media-libs/gstreamer-0.10</pkg></flag>
30
31 This is invalid. Replacing invalid package names with other invalid
32 names is no fix. It is ugly Gentoo-style hackery which proves that
33 developers prefer trying randomly changing something until QA check
34 doesn't trigger over reading the documentation. As a result, now
35 a number packages with visible QA issues have been turned into a number
36 of packages with QA issues that aren't caught by the schema due to
37 regexp limitations.
38
39 Please go over all the packages you've touched and fix the silent
40 issues you introduced. I can't afford to waste more time writing more
41 complex QA checks that are going to cover all the ways Gentoo
42 developers can screw up such a simple thing as package *name*.
43
44 > <flag name="qml">Build QML/QtQuick bindings and imports</flag>
45 > <flag name="widgets">Build the QtMultimediaWidgets module</flag>
46 > </use>
47 >
48
49
50
51 --
52 Best regards,
53 Michał Górny
54 <http://dev.gentoo.org/~mgorny/>

Replies