| 1 |
On Thu, May 06, 2010 at 04:06:39AM +0200, Sebastian Pipping wrote: |
| 2 |
> .. and that they need to be split smartly to keep each working in a |
| 3 |
> shared codebase. python modules and three entry point scripts on it |
| 4 |
> could work. |
| 5 |
+1 on that. |
| 6 |
|
| 7 |
> package_pattern = |
| 8 |
> re.compile('\\b(?P<category>[a-z0-9_+-]+-[a-z0-9_+-]+)/(?P<package>[a-z0-9_+-]+(?:[a-z_+]+[0-9]+|[a-z0-9_+-]+[a-z+]+))') |
| 9 |
- Fails to match category 'virtual'. |
| 10 |
- That PV matching looks really fishy. |
| 11 |
- I would probably just steal the pkgatom stuff from pkgcore/Portage, as |
| 12 |
that's already a fairly canonical regex. |
| 13 |
|
| 14 |
> - If you stick with the original pattern, this patch may still help: |
| 15 |
> http://git.goodpoint.de/?p=eassign.git;a=commitdiff;h=7ad3cd607589aba7a1528dbd0744a942d18065eb |
| 16 |
I think most of this might have already from from one the above. |
| 17 |
|
| 18 |
> > How is it integrated into workflow? |
| 19 |
> > =================================== |
| 20 |
> > [..] |
| 21 |
> > 5. Javascript then appends the server results into the "Additional |
| 22 |
> > Comments" box: a suggested assignee and suggested CC values, with logic |
| 23 |
> > as to why. |
| 24 |
> assign.py does not explain reasoning, yet. |
| 25 |
Ok, major todo on adding it, see below for why. |
| 26 |
|
| 27 |
> > Assignment/CC computing: |
| 28 |
> > ======================== |
| 29 |
> > Step 1 - Summary line processing |
| 30 |
> > -------------------------------- |
| 31 |
> > [..] |
| 32 |
> > 3. Process ALL atoms in the summary line, using any after the first for CC |
| 33 |
> > only. (new in v4) |
| 34 |
> |
| 35 |
> I'm unsure about the handling of order: |
| 36 |
> it wouldn't work well for "dependency foo/bar missing on foo2/bar2". |
| 37 |
That's part of why the reasoning output was needed. |
| 38 |
The full output for that should be something like: |
| 39 |
========= |
| 40 |
Combined: |
| 41 |
--------- |
| 42 |
To: $ADDR1 |
| 43 |
CC: $ADDR2,$ADDR3 |
| 44 |
Ignoring: $ADDR4, $ADDR5 |
| 45 |
|
| 46 |
For foo/bar: |
| 47 |
------------ |
| 48 |
To: ... |
| 49 |
CC: ... |
| 50 |
Ignoring: ... |
| 51 |
|
| 52 |
For foo2/bar2: |
| 53 |
-------------- |
| 54 |
To: ... |
| 55 |
CC: ... |
| 56 |
Ignoring: ... |
| 57 |
========= |
| 58 |
(optionally with some CLI options to say give only the combined |
| 59 |
version). |
| 60 |
|
| 61 |
> > Step 2 - Metadata.xml contains only a herd |
| 62 |
> > ------------------------------------------ |
| 63 |
> > 1. Take the herd element, and look up the herd in herds.xml to convert |
| 64 |
> > to an email address. This email address must be a valid bugzilla |
| 65 |
> > account. |
| 66 |
> This may need a replacement map. Think media-video versus video, |
| 67 |
> perl-bugs versus perl, etc. |
| 68 |
I'm saying the replacement map IS from the herds.xml data. For herds |
| 69 |
that have multiple emails (normal mail vs. bugzilla address), we really |
| 70 |
need to find a way to document both of them in herds.xml. |
| 71 |
|
| 72 |
-- |
| 73 |
Robin Hugh Johnson |
| 74 |
Gentoo Linux: Developer, Trustee & Infrastructure Lead |
| 75 |
E-Mail : robbat2@g.o |
| 76 |
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 |
Archives