| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 07/10/12 02:56 PM, justin wrote: |
| 5 |
> On 10/7/12 8:19 PM, Chí-Thanh Christopher Nguyễn wrote: |
| 6 |
>> justin schrieb: |
| 7 |
>>> Hi, |
| 8 |
>>> |
| 9 |
>>> I want to add following change to fortran-2.eclass to achieve |
| 10 |
>>> more simpler usage. |
| 11 |
>>> |
| 12 |
>>> The patch will make the eclass depend on virtual/fortran so |
| 13 |
>>> that no manual addition is needed. Two exception are present, |
| 14 |
>>> a) the ebuild has the USE flag fortran, then we check for that, |
| 15 |
>>> or b) the FORTRAN_OPTIONAL variable is set, which leaves the |
| 16 |
>>> control to the ebuild (e.g. for cases like "lapack? ( |
| 17 |
>>> virtual/fortran )"). |
| 18 |
>> |
| 19 |
>> I suggest that you do something similar to the XORG_DRI variable |
| 20 |
>> in xorg-2.eclass. |
| 21 |
>> |
| 22 |
>> For example: FORTRAN_WANT_COMPILER=no would not add a |
| 23 |
>> virtual/fortran dependency FORTRAN_WANT_COMPILER=always would |
| 24 |
>> unconditionally depend on virtual/fortran |
| 25 |
>> FORTRAN_WANT_COMPILER=useflag would depend on useflag? ( |
| 26 |
>> virtual/fortran ) |
| 27 |
>> |
| 28 |
>> To avoid breaking existing packages, you could default to |
| 29 |
>> FORTRAN_WANT_COMPILER=fortran |
| 30 |
>> |
| 31 |
>> |
| 32 |
>> Best regards, Chí-Thanh Christopher Nguyễn |
| 33 |
>> |
| 34 |
>> |
| 35 |
> |
| 36 |
> Thanks for that suggestion. Please find the new version attached. |
| 37 |
> It basically follows what is done in the xorg-2.eclass. But we |
| 38 |
> allow a list of USE and don't allow a no, because the eclass itself |
| 39 |
> needs a fortran compiler. |
| 40 |
> |
| 41 |
> Thanks, justin |
| 42 |
|
| 43 |
|
| 44 |
Looks better, but it would still be a good idea to have a possibility |
| 45 |
of setting FORTRAN_SUPPORT=no so that the eclass can be used without |
| 46 |
setting *DEPEND if a dev so desires. |
| 47 |
|
| 48 |
Right now it looks like FORTRAN_SUPPORT=no would result in |
| 49 |
DEPEND+="no? (virtual/fortran)" |
| 50 |
-----BEGIN PGP SIGNATURE----- |
| 51 |
Version: GnuPG v2.0.19 (GNU/Linux) |
| 52 |
|
| 53 |
iF4EAREIAAYFAlB0IrMACgkQ2ugaI38ACPDCUAEAnMHvFfUv66mawyHc1cY7E6V3 |
| 54 |
de/3vSIcxPDjNuHLFlMA/Arhg6q0M2E3ECUZI83WYdNkKEQPSoD4uhqbD41X2VoO |
| 55 |
=8oKW |
| 56 |
-----END PGP SIGNATURE----- |
Archives