| 1 |
>>>>> On Sat, 27 Mar 2021, Sam James wrote: |
| 2 |
|
| 3 |
> -if [[ -z ${_AUTOTOOLS_ECLASS} ]]; then |
| 4 |
> +if [[ -z ${_AUTOTOOLS_ECLASS} ]] ; then |
| 5 |
|
| 6 |
This just adds unnecessary noise to the git history. We don't have any |
| 7 |
policy on whitespace before punctuation marks, but the examples in the |
| 8 |
Bash manual don't have whitespace before semicolons. (Several more of |
| 9 |
these changes in the reset of the commit.) |
| 10 |
|
| 11 |
> - # Subdirs often share a common build dir #529404. If so, we can't safely |
| 12 |
> + # Subdirs often share a common build dir, bug #529404. If so, we can't safely |
| 13 |
|
| 14 |
Long line. |
| 15 |
|
| 16 |
> - if [[ ${EBUILD_PHASE} != "unpack" && ${EBUILD_PHASE} != "prepare" ]]; then |
| 17 |
> - ewarn "QA Warning: running $1 in ${EBUILD_PHASE} phase" |
| 18 |
> + if [[ ${EBUILD_PHASE_FUNC} != "src_unpack" && ${EBUILD_PHASE_FUNC} != "src_prepare" ]] ; then |
| 19 |
> + eqawarn "Running '${1}' in ${EBUILD_PHASE_FUNC} phase" |
| 20 |
|
| 21 |
What is wrong with checking EBUILD_PHASE? |
| 22 |
|
| 23 |
Ulrich |
Archives