Archives
Archives
| From: | David Seifert <soap@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o, Sam James <sam@g.o> | ||
| Subject: | Re: [gentoo-dev] [PATCH] autotools.eclass: eclassdoc, cosmetic changes, drop old EAPIs | ||
| Date: | Sun, 28 Mar 2021 09:52:43 | ||
| Message-Id: | 124a5f6629c7138a1ba7d63f6ffd3c35d4b60719.camel@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] [PATCH] autotools.eclass: eclassdoc, cosmetic changes, drop old EAPIs by Ulrich Mueller |
||
| 1 | On Sun, 2021-03-28 at 10:13 +0200, Ulrich Mueller wrote: |
| 2 | > > > > > > On Sat, 27 Mar 2021, Sam James wrote: |
| 3 | > |
| 4 | > > -if [[ -z ${_AUTOTOOLS_ECLASS} ]]; then |
| 5 | > > +if [[ -z ${_AUTOTOOLS_ECLASS} ]] ; then |
| 6 | > |
| 7 | > This just adds unnecessary noise to the git history. We don't have any |
| 8 | > policy on whitespace before punctuation marks, but the examples in the |
| 9 | > Bash manual don't have whitespace before semicolons. (Several more of |
| 10 | > these changes in the reset of the commit.) |
| 11 | |
| 12 | This is just bringing it in line with the rest of the eclass. You know, |
| 13 | consistency. |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH] autotools.eclass: eclassdoc, cosmetic changes, drop old EAPIs | Ulrich Mueller <ulm@g.o> |