| 1 |
>>>>> On Sat, 14 Aug 2021, Rolf Eike Beer wrote: |
| 2 |
|
| 3 |
> The default owner is root:root anyway, so just make sure other settings do not |
| 4 |
> leak outside from the places where it is actually used. This also fixes |
| 5 |
> qmail_supervise_install_one() when called from outside of qmail_src_install(). |
| 6 |
|
| 7 |
Looking at this patch again, I wonder about two points in general: |
| 8 |
|
| 9 |
- diropts -m 0755 shouldn't be necessary. 0775 is dodir's default, and I |
| 10 |
don't see any diropts with another -m option in the eclass. |
| 11 |
|
| 12 |
- insinto ...; insopts -m 0755; doins ... presumably indicates that the |
| 13 |
wrong tool is used, i.e. it should be exeinto ...; doexe ... instead. |
| 14 |
doexe already defaults to file mode 0755. |
| 15 |
|
| 16 |
Ulrich |
Archives