| 1 |
Am Samstag, 14. August 2021, 12:52:15 CEST schrieb Ulrich Mueller: |
| 2 |
> >>>>> On Sat, 14 Aug 2021, Rolf Eike Beer wrote: |
| 3 |
> > The default owner is root:root anyway, so just make sure other settings do |
| 4 |
> > not leak outside from the places where it is actually used. This also |
| 5 |
> > fixes qmail_supervise_install_one() when called from outside of |
| 6 |
> > qmail_src_install(). |
| 7 |
> Looking at this patch again, I wonder about two points in general: |
| 8 |
> |
| 9 |
> - diropts -m 0755 shouldn't be necessary. 0775 is dodir's default, and I |
| 10 |
> don't see any diropts with another -m option in the eclass. |
| 11 |
> |
| 12 |
> - insinto ...; insopts -m 0755; doins ... presumably indicates that the |
| 13 |
> wrong tool is used, i.e. it should be exeinto ...; doexe ... instead. |
| 14 |
> doexe already defaults to file mode 0755. |
| 15 |
|
| 16 |
You are absolutely right. I suspect the code simply predates those helpers, |
| 17 |
I'm going to clean this up. It will often not reduce the amount of calls as |
| 18 |
there are several things that get installed with different group and |
| 19 |
permissions. |
| 20 |
|
| 21 |
Sadly the docs at https://devmanual.gentoo.org/function-reference/install-functions/ do not show the defaults, is there a better place to looks at? |
| 22 |
|
| 23 |
Eike |
Archives