| 1 |
On Tue, Nov 29, 2016 at 6:57 PM, Brian Dolbec <dolsen@g.o> wrote: |
| 2 |
> |
| 3 |
> While working on the last 2 version bumps to the twisted package, I |
| 4 |
> kept getting an error in which the *egg-info/SOURCES.txt file absolute |
| 5 |
> paths for all the files found in that very same directory. They are |
| 6 |
> required to be relative paths only. This problem currently only affects |
| 7 |
> some pkgs depending on the setuptools pkg for install. The source of |
| 8 |
> the change is that setuptools patches the cpython findall() with one |
| 9 |
> that returns relative paths for anything in/below the passed in base |
| 10 |
> directory. Everything else it returns the absolute path. |
| 11 |
> |
| 12 |
> Why we should apply this: |
| 13 |
> |
| 14 |
> Python upstream has merged the setuptools findall() code and will be |
| 15 |
> included in the next releases of python, 2.7.13, 3.4.6, 3.5.4 (I |
| 16 |
> think). So, there is potential for many more python pkgs to be |
| 17 |
> affected by this that are not requiring setuptools for install. |
| 18 |
> Without the ebb-base setting, the egg-info/* files are not included |
| 19 |
> in SOURCES.txt. The install proceeds without error. |
| 20 |
> |
| 21 |
> NOTE: This first affects the python_compile_all phase, long before |
| 22 |
> it even tries to run the tests (if enabled). |
| 23 |
> |
| 24 |
> |
| 25 |
> Some history: |
| 26 |
> |
| 27 |
> The egg-base settings were originally added for parallel |
| 28 |
> testing/install purposes. They are not used due to problems in |
| 29 |
> parallelizing testing, etc.. (something along those lines, I |
| 30 |
> don't want to search thru the logs, and mails to see what Michal's |
| 31 |
> original words were about it.) |
| 32 |
> |
| 33 |
> I am working on twisted-16.5.0 and 16.6.0 releases (tests are still |
| 34 |
> failing), but 16.6.0 has many improvements to the testing code, so has a |
| 35 |
> lot fewer errors to fix. Once these are fixed and the eclass changes |
| 36 |
> are merged, I will be able to add it to the tree. |
| 37 |
> |
| 38 |
> See attached patch. NOTE: actual commit message will be |
| 39 |
> different/updated correctly. This was just an interim patch for |
| 40 |
> testing and initial review. |
| 41 |
> |
| 42 |
|
| 43 |
Seems ok to me. Hopefully it doesn't break something in a subtle, hard |
| 44 |
to detect way. ;-) |
Archives