Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: yngwin@g.o
Subject: Re: [gentoo-dev] Re: Patch: Linguas USE support for cmake-utils.eclass
Date: Sun, 24 Jun 2012 14:45:51
Message-Id: 20120624164336.0a8efebc@pomiocik.lan
In Reply to: Re: [gentoo-dev] Re: Patch: Linguas USE support for cmake-utils.eclass by Ben de Groot
On Sun, 24 Jun 2012 22:23:17 +0800
Ben de Groot <yngwin@g.o> wrote:

> On 24 June 2012 21:56, Michael Palimaka <kensington@g.o> wrote: > > On 2012-06-24 18:34, Ben de Groot wrote: > >> > >> We at qt@ have been discussing this on and off. We would like to > >> see a linguas.eclass happen, because already now we start having > >> code duplication. So instead of this duplication of code between > >> qt4-r2 and cmake-utils eclasses, why not put this into a separate > >> linguas.eclass that both can inherit? > > Actually, I was just thinking, since we are talking about two > variables and a few lines of code, maybe it would be better to add > this to base.eclass?
That would change its API and result in possible lot of broken ebuilds. Not to mention that base eclass currently doesn't require adding additional phase functions to actually handle what it sets. -- Best regards, Michał Górny


File name MIME type
signature.asc application/pgp-signature