| 1 |
On Mon, Oct 24, 2011 at 03:46, Michał Górny wrote: |
| 2 |
> On Mon, 24 Oct 2011 03:42:24 +0000 Nathan Phillip Brink wrote: |
| 3 |
>> On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote: |
| 4 |
>> > --- |
| 5 |
>> > scons-utils.eclass | 33 +++++++++++++++++++++++++-------- |
| 6 |
>> > 1 files changed, 25 insertions(+), 8 deletions(-) |
| 7 |
>> ... |
| 8 |
>> > +# @ECLASS-VARIABLE: myesconsargs |
| 9 |
>> > +# @DEFAULT_UNSET |
| 10 |
>> > +# @DESCRIPTION: |
| 11 |
>> > +# List of package-specific options to pass to all SCons calls. |
| 12 |
>> > Supposed to be +# set in src_configure(). |
| 13 |
>> |
| 14 |
>> Shouldn't this variable be named MYESCONSARGS since it is being |
| 15 |
>> introduced into the global scope? |
| 16 |
> |
| 17 |
> I can't deny that but I'd like to keep it consistent with cmake-utils |
| 18 |
> and autotools-utils. Alternate approach would be to make it local to |
| 19 |
> src_configure() and add scons-utils_src_configure() which would export |
| 20 |
> it under internal name but I don't think that's really worth the effort. |
| 21 |
|
| 22 |
sounds like you want @VARIABLE and not @ECLASS-VARIABLE |
| 23 |
-mike |
Archives