| 1 |
On Tue, 25 Oct 2011 01:57:11 -0400 |
| 2 |
Mike Frysinger <vapier@g.o> wrote: |
| 3 |
|
| 4 |
> On Mon, Oct 24, 2011 at 03:46, Michał Górny wrote: |
| 5 |
> > On Mon, 24 Oct 2011 03:42:24 +0000 Nathan Phillip Brink wrote: |
| 6 |
> >> On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote: |
| 7 |
> >> > --- |
| 8 |
> >> > scons-utils.eclass | 33 +++++++++++++++++++++++++-------- |
| 9 |
> >> > 1 files changed, 25 insertions(+), 8 deletions(-) |
| 10 |
> >> ... |
| 11 |
> >> > +# @ECLASS-VARIABLE: myesconsargs |
| 12 |
> >> > +# @DEFAULT_UNSET |
| 13 |
> >> > +# @DESCRIPTION: |
| 14 |
> >> > +# List of package-specific options to pass to all SCons calls. |
| 15 |
> >> > Supposed to be +# set in src_configure(). |
| 16 |
> >> |
| 17 |
> >> Shouldn't this variable be named MYESCONSARGS since it is being |
| 18 |
> >> introduced into the global scope? |
| 19 |
> > |
| 20 |
> > I can't deny that but I'd like to keep it consistent with |
| 21 |
> > cmake-utils and autotools-utils. Alternate approach would be to |
| 22 |
> > make it local to src_configure() and add |
| 23 |
> > scons-utils_src_configure() which would export it under internal |
| 24 |
> > name but I don't think that's really worth the effort. |
| 25 |
> |
| 26 |
> sounds like you want @VARIABLE and not @ECLASS-VARIABLE |
| 27 |
|
| 28 |
Thanks, fixed. |
| 29 |
|
| 30 |
-- |
| 31 |
Best regards, |
| 32 |
Michał Górny |
Archives