| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 02/07/14 01:24 AM, Ulrich Mueller wrote: |
| 5 |
>>>>>> On Tue, 01 Jul 2014, Ian Stakenvicius wrote: |
| 6 |
> |
| 7 |
>> On 01/07/14 06:44 PM, Ciaran McCreesh wrote: |
| 8 |
>>>> || ( amd64? ( |
| 9 |
>>> |
| 10 |
>>> I thought we were trying to discourage that abomination... |
| 11 |
> |
| 12 |
>> It's still necessary, unfortunately, until such time as |
| 13 |
>> everything in the tree no longer needs/depends on the emul-* |
| 14 |
>> packages (see news item #8 for progress). Otherwise, end-users |
| 15 |
>> would end up with dependency collisions. |
| 16 |
> |
| 17 |
> Sure, the second block is needed, but the point is that foo? ( ) |
| 18 |
> conditionals inside a || ( ) group should be avoided. |
| 19 |
> |
| 20 |
|
| 21 |
Ahh, sorry, missed that point entirely. |
| 22 |
|
| 23 |
|
| 24 |
> I wonder if the dependency couldn't be written like this, without |
| 25 |
> the amd64? () conditional: |
| 26 |
> |
| 27 |
> || ( ( |
| 28 |
>> =dev-libs/glib-2.34.3:2[abi_x86_32(-)] |
| 29 |
>> =virtual/opengl-7.0-r1[abi_x86_32(-)] |
| 30 |
> ) ( app-emulation/emul-linux-x86-baselibs[-abi_x86_32(-)] |
| 31 |
> app-emulation/emul-linux-x86-opengl[-abi_x86_32(-)] ) ) |
| 32 |
> |
| 33 |
> emul-linux-x86-* doesn't have keywords other than amd64, so it |
| 34 |
> won't match on non-amd64 anyway. |
| 35 |
> |
| 36 |
|
| 37 |
LGTM, will test tomorrow and confirm. |
| 38 |
|
| 39 |
-----BEGIN PGP SIGNATURE----- |
| 40 |
Version: GnuPG v2.0.22 (GNU/Linux) |
| 41 |
|
| 42 |
iF4EAREIAAYFAlOzm3cACgkQ2ugaI38ACPCloQD/fKfmTkG9yp+e/D+tK7Xmiepb |
| 43 |
SKPlIk9tcoUzF0h8aToBAIqAjG8hcRKzuwoHOytpEekxVV29HWgWe+2xD6Q37T/r |
| 44 |
=XYoV |
| 45 |
-----END PGP SIGNATURE----- |
Archives