| 1 |
>>>>> On Tue, 01 Jul 2014, Ian Stakenvicius wrote: |
| 2 |
|
| 3 |
> On 01/07/14 06:44 PM, Ciaran McCreesh wrote: |
| 4 |
>>> || ( amd64? ( |
| 5 |
>> |
| 6 |
>> I thought we were trying to discourage that abomination... |
| 7 |
|
| 8 |
> It's still necessary, unfortunately, until such time as everything |
| 9 |
> in the tree no longer needs/depends on the emul-* packages (see news |
| 10 |
> item #8 for progress). Otherwise, end-users would end up with |
| 11 |
> dependency collisions. |
| 12 |
|
| 13 |
Sure, the second block is needed, but the point is that foo? ( ) |
| 14 |
conditionals inside a || ( ) group should be avoided. |
| 15 |
|
| 16 |
I wonder if the dependency couldn't be written like this, without the |
| 17 |
amd64? () conditional: |
| 18 |
|
| 19 |
|| ( |
| 20 |
( |
| 21 |
>=dev-libs/glib-2.34.3:2[abi_x86_32(-)] |
| 22 |
>=virtual/opengl-7.0-r1[abi_x86_32(-)] |
| 23 |
) |
| 24 |
( |
| 25 |
app-emulation/emul-linux-x86-baselibs[-abi_x86_32(-)] |
| 26 |
app-emulation/emul-linux-x86-opengl[-abi_x86_32(-)] |
| 27 |
) |
| 28 |
) |
| 29 |
|
| 30 |
emul-linux-x86-* doesn't have keywords other than amd64, so it won't |
| 31 |
match on non-amd64 anyway. |
| 32 |
|
| 33 |
Ulrich |
Archives